tag:blogger.com,1999:blog-11485756.post5113956724922159182..comments2023-09-25T12:19:44.716+02:00Comments on Thomas Ferris Nicolaisen's blog: MetricsThomas Ferris Nicolaisen http://www.blogger.com/profile/17464665832399025601noreply@blogger.comBlogger2125tag:blogger.com,1999:blog-11485756.post-78839851546709072712010-06-05T00:57:08.383+02:002010-06-05T00:57:08.383+02:00Thanks for the comment, Thommy.
I don't think...Thanks for the comment, Thommy.<br /><br />I don't think ZWP is particularly demotivating or the opposite. It's more of a focus thing. If you mandate ZWP, you tell the team we're gonna have a strict no-new-warnings policy, and then introduce new warnings one by one. ZWP means turning off *most* of the warnings in the system so you get down to zero. It's easy and clean, but then again you shut your eyes to all the warnings that are not enabled (until you one day enable them again, but that will take a while). <br /><br />We haven't defined any goals around the metrics yet, except for (a) we want higher test coverage, and (b) we want to avoid FindBugs bugs. These are just general advice, not hard goals.<br /><br />I realize that static code analysis is a bit dangerous. It's a very one-dimensional way to criticize code, and I think if you have a problem with high avg. complexity per method, for instance, you're not gonna get anywhere by bitching about the high complexity per method number. You're better off realizing that perhaps there is a problem here, that people don't dare to extract method and do more object-oriented code.Thomas Ferris Nicolaisen https://www.blogger.com/profile/17464665832399025601noreply@blogger.comtag:blogger.com,1999:blog-11485756.post-77540072179319696282010-06-03T21:54:27.005+02:002010-06-03T21:54:27.005+02:00Thanks for a nice post Thomas!
Zero warning polic...Thanks for a nice post Thomas!<br /><br />Zero warning policy on the CI for a already legacy system might be as you say not a positive thing. It will probably demotivate people rather than inspire them.<br /><br />I would check the metrics and take it up with a team member one on one during a lunch or some other time that you can catch a developer alone. I would ask that person for help with the problem. Maybe this person will find some way of helping you without you bringing it up for everyone. Maybe you could ask more than one person as well? Have another coffee later that day with another person?<br /><br />Have a goal is also important. Why is it being measured? What do we achieve by having a zero-warning policy? And are we measuring what we gain by it?<br /><br />Thanks again for a nice post :)<br /><br />ThommyThommy Bommenhttps://www.blogger.com/profile/02386501747333360774noreply@blogger.com